[erlang-bugs] The latest Emacs from CVS doesn't like the backuotes from erlang.el

[Balint Reczey]

Hi,
My original intention was the same, but the new style backqoutes was
introduced in Emacs 19.29,
( http://www.gnu.org/software/emacs/elisp/html_node/Backquote.html )
and erlang.el contains compatibility workarounds for Emacs 18:

;;; Avoid errors while compiling this file.

;; `eval-when-compile' is not defined in Emacs 18.  We define it as a
;; no-op.
(or (fboundp 'eval-when-compile)
    (defmacro eval-when-compile (&rest rest) nil))

Replacing the old style backquotes whith new style ones would break
compatibility with Emacs 18, so i just expanded them.

Regards,
Balint


2008. 10. 16, csütörtök keltezéssel 22.01-kor Robert Virding ezt írta:
> This fix just expands the backquote/unquote forms by hand. I have here
> a better fix (I think) which uses the "new" backquote style. This has
> been around a long while, and is compatible with Common Lisp
> backquote. We'll see if it makes it through, I have also included the
> file.
> 
> Compiling erlang.el with Emacs 22.1 also gives some obsolete
> functions, but they seem to be for this version of Emacs.
> 
> Robert
> 
> *** erlang.el.orig    Thu Oct 16 21:33:08 2008
> --- erlang.el    Thu Oct 16 21:36:45 2008
> ***************
> *** 1891,1895 ****
>         "(unless CONDITION BODY...): If CONDITION is false, do BODY,
> else return nil."
> !       (` (if (, condition) 
> !          nil 
> !        (,@ body)))))
>   
> --- 1891,1895 ----
>         "(unless CONDITION BODY...): If CONDITION is false, do BODY,
> else return nil."
> !       `(if ,condition 
> !        nil 
> !      ,@REDACTED)))
>   
> ***************
> *** 1898,1902 ****
>         "(when CONDITION BODY...): If CONDITION is true, do BODY, else
> return nil."
> !       (` (if (, condition)
> !          (progn (,@ body)) 
> !        nil))))
>   
> --- 1898,1902 ----
>         "(when CONDITION BODY...): If CONDITION is true, do BODY, else
> return nil."
> !       `(if ,condition
> !        (progn ,@REDACTED)
> !      nil)))
>   
> ***************
> *** 1905,1907 ****
>         "Return the character in the current buffer just before POS."
> !       (` (char-after (1- (or (, pos) (point)))))))
>   
> --- 1905,1907 ----
>         "Return the character in the current buffer just before POS."
> !       `(char-after (1- (or ,pos (point))))))
> 
> 
> 2008/10/16 Balint Reczey <Balint.Reczey@REDACTED>
>         Hi,
>         I tried to submit the patch to erlang-bugs several times, but
>         somehow it
>         did not get through the spam filter/listadmin. :-(
>         
>         You can find the patch here:
>         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494823
>         
>         Regards,
>         Balint
>         
>         2008. 10. 16, csütörtök keltezéssel 09.12-kor Sergey A. ezt
>         írta:
>         
>         > Hello.
>         >
>         > The latest Emacs from CVS doesn't like the backuotes from
>         erlang.el
>         > --
>         >
>         > When I open any *.erl file in my emacs then the following
>         warning
>         > message is shown:
>         >
>         > "Loading `erlang': old-style backquotes detected!"
>         >
>         > I know this bug is of little importance, but maybe there is
>         an easy
>         > way to modify the erlang.el in such a way that all
>         backquotes become
>         > correct.
>         >
>         > Unfortunately, I have not got working knowledge of Lisp and
>         don't know
>         > what "backquotes" are :(
>         >
>         > I use erlang.el coming with Erlang R12B.3 and the latest
>         emacs from
>         > CVS (v23.0.60.1).
>         >
>         > Thanks.
>         >
>         > --
>         > Sergey
>         > _______________________________________________
>         > erlang-bugs mailing list
>         > erlang-bugs@REDACTED
>         > http://www.erlang.org/mailman/listinfo/erlang-bugs
>         _______________________________________________
>         erlang-bugs mailing list
>         erlang-bugs@REDACTED
>         http://www.erlang.org/mailman/listinfo/erlang-bugs
> 
>